add new utf8proc_codepoint_units function #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe |
|
Hmm, the term sizeof in C has special meaning, here the functions is meant to obtain a variable number between 0 and 4 which to me is the opposite of what "sizeof" sounds to me which always evaluates to a constant object size. Other alternatives:
|
|
sizeof refers to a size in bytes, which is why it seems appropriate here. |
|
Updated. |
stevengj
reviewed
Feb 12, 2020
| (void) argv; /* unused */ | ||
|
|
||
| /* some simple sanity tests of */ | ||
| for (c = 0; c < 0x80; c++) { |
There was a problem hiding this comment.
It would be good to check consistency with utf8proc_encode_char, i.e. check utf8proc_sizeof_char(c) == utf8proc_encode_char(c, buf) where you declare utf8proc_uint8_t buf[4].
|
Not sure what the Travis failure is here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose a simple function to determine the number of UTF-8 bytes that a codepoint require. This mostly addresses the issue #170
Example: